We’re having a problem with displaying unicode characters when the users’ PC isn’t set up in a certain way. The UI incorrectly displays non-Latin characters.
This may be because github is not recognizing some files as UTF-8.
See this discussion thread here:
*.cpp text diff=cpp working-tree-encoding=UTF-8
*.c text diff=cpp working-tree-encoding=UTF-8
*.h text diff=cpp working-tree-encoding=UTF-8
*.hpp text diff=cpp working-tree-encoding=UTF-8
I believe this is exactly the problem… Like I mentioned I have my Atom editor set at UTF-8 and the app(s) compile fine without the added chars on the unicode chars. If I change this then the files(s) are not interpreted correctly and the extraneous char(s) show up.
In other words if I compile the exact same code Github just compiled, I get the correct chars, while Github does not. I believe that indeed there it could be something incorrect in the .gitattributes file that’s causing Github to not recognize the files as UTF-8.
Can we just create a test branch and adjust the gitattributes to see what works?
Hmmm… Well that would seem to indicate there’s something in the Windows build chain on Github that’s not handling the source files as UTF-8? I don’t have the issue with my local builds, and for the heck of it I checked a recent Valentina Gitlab build and there is no issue there either.
Sorry, only seeing this now. Having power & water issues again.
The % is still looking the same:
I’m still wondering if it’s not the MS Visual C++, since this only started when I had to download and install that along with the 1st build.
Something else that happens from time to time that I can’t quite put my finger on, is that it seems to almost hang while doing certain tasks, just long enough to let me think ‘What now?’ but then it goes on. I haven’t been able to quite predict which tasks yet.